feat: Inline tag creation in /inc lifecycle modals#244
Open
spalmurray wants to merge 10 commits into
Open
Conversation
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
…sensitive tag uniqueness at the database level
spalmurray
force-pushed
the
spalmurray/RELENG-768
branch
from
5de96ba to
3ea47ac
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ea47ac. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…inline tag creation race recovery
…nstead of a DB constraint and race recovery
spalmurray
commented
Jun 12, 2026
| "Could not resolve Slack user %s to a Firetower user", | ||
| form["captain_slack_id"], | ||
| # Work runs after ack() so the modal closes immediately; any failure is | ||
| # reported back to the submitter as an ephemeral message. |
Contributor
Author
There was a problem hiding this comment.
concerned about hitting 3s ack timeout without this
taylor-osler-sentry
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds inline affected-service/region tag creation from the Slack lifecycle modals. The tag autocomplete offers a "+ Create " option (service/region only; impact_type stays curated) that get_or_creates the tag with the right type on submission, dedupes case-insensitively, handles uniqueness races, and degrades gracefully when the DB is unreachable. Closes RELENG-768.